From: Yegor Yefremov <yegorslists@googlemail.com>
Date: Mon, 20 Apr 2015 14:30:56 +0000 (+0200)
Subject: cert_data: fix memory leak
X-Git-Tag: v2.4_alpha1~290
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7d30696ac51aa9649f2290ada2c0fb5865cfe859;p=thirdparty%2Fopenvpn.git

cert_data: fix memory leak

Release pCertName, if SecCertificateCopyValues() fails.

Found via cppcheck.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Vasily Kulikov <segoon@openwall.com>
Acked-by: Vasily Kulikov <segoon@openwall.com>
Message-Id: <1429540256-4906-1-git-send-email-yegorslists@googlemail.com>
URL: http://article.gmane.org/gmane.network.openvpn.devel/9600
Signed-off-by: Gert Doering <gert@greenie.muc.de>
---

diff --git a/contrib/keychain-mcd/cert_data.c b/contrib/keychain-mcd/cert_data.c
index f2b33edce..a04bf79c3 100644
--- a/contrib/keychain-mcd/cert_data.c
+++ b/contrib/keychain-mcd/cert_data.c
@@ -146,6 +146,7 @@ CFArrayRef GetFieldsFromCertificate(SecCertificateRef certificate, CFTypeRef oid
       printErrorMsg("GetFieldsFromCertificate: SecCertificateCopyValues", error);
       CFRelease(keySelection);
       CFRelease(fields);
+      destroyCertName(pCertName);
       return NULL;
   }
   CFDictionaryRef vals = CFDictionaryGetValue(dict, oid);