From: Dylan William Hardison <dylan@hardison.net>
Date: Thu, 26 Oct 2017 21:28:41 +0000 (-0400)
Subject: no bug - document code and fix single-arg bless()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7d35b918dba36abb75e4a8d41455b9ded3032969;p=thirdparty%2Fbugzilla.git

no bug - document code and fix single-arg bless()
---

diff --git a/Bugzilla/ModPerl/StartupFix.pm b/Bugzilla/ModPerl/StartupFix.pm
index e6e0e5f43..bcc467e9f 100644
--- a/Bugzilla/ModPerl/StartupFix.pm
+++ b/Bugzilla/ModPerl/StartupFix.pm
@@ -12,17 +12,25 @@ use warnings;
 use Filter::Util::Call;
 use Apache2::ServerUtil ();
 
+# This module is a source filter that removes every subsequent line
+# if this is the first time apache has started,
+# as reported by Apache2::ServerUtil::restart_count(), which is 1
+# on the first start.
+
 my $FIRST_STARTUP = <<'CODE';
 warn "Bugzilla::ModPerl::StartupFix: Skipping first startup using source filter\n";
 1;
 CODE
 
 sub import {
-    my ($type) = @_;
+    my ($class) = @_;
     my ($ref)  = {};
-    filter_add( bless $ref );
+    filter_add( bless $ref, $class );
 }
 
+# this will be called for each line.
+# For the first line replaced, we insert $FIRST_STARTUP.
+# Every subsequent line is replaced with an empty string.
 sub filter {
     my ($self) = @_;
     my ($status);