From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Mon, 21 Feb 2022 18:22:09 +0000 (+0100)
Subject: CLEANUP: quic: Useless tests in qc_try_rm_hp()
X-Git-Tag: v2.6-dev3~84
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7d845f15fd438a2cecd6758e5081b160afb8cc8c;p=thirdparty%2Fhaproxy.git

CLEANUP: quic: Useless tests in qc_try_rm_hp()

There is no need to test <qel>. Furthermore the packet type has already checked
by the caller.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 314ed2a9de..cb99826ceb 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -3805,7 +3805,7 @@ static inline int qc_try_rm_hp(struct quic_conn *qc,
 		pkt->aad_len = pn - beg + pkt->pnl;
 		qpkt_trace = pkt;
 	}
-	else if (qel) {
+	else {
 		if (qel->tls_ctx.rx.flags & QUIC_FL_TLS_SECRETS_DCD) {
 			/* If the packet number space has been discarded, this packet
 			 * will be not parsed.
@@ -3819,10 +3819,6 @@ static inline int qc_try_rm_hp(struct quic_conn *qc,
 		MT_LIST_APPEND(&qel->rx.pqpkts, &pkt->list);
 		quic_rx_packet_refinc(pkt);
 	}
-	else {
-		TRACE_PROTO("Unknown packet type", QUIC_EV_CONN_TRMHP, qc);
-		goto err;
-	}
 
 	*el = qel;
 	/* No reference counter incrementation here!!! */