From: Volker Lendecke <vl@samba.org>
Date: Fri, 26 Oct 2018 06:25:14 +0000 (+0200)
Subject: lib: Use dom_sid_str_buf
X-Git-Tag: tdb-1.3.17~948
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7d958162bf45fe582b1a4fe30f0e5ffba1325e97;p=thirdparty%2Fsamba.git

lib: Use dom_sid_str_buf

This is the one place where we have to do another strpcy. Many of the
sid_to_fstring calls should be replacable by dom_sid_str_buf, so this
will get less.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/lib/util_sid.c b/source3/lib/util_sid.c
index 4d57a92b853..13d5e1ce4c4 100644
--- a/source3/lib/util_sid.c
+++ b/source3/lib/util_sid.c
@@ -34,7 +34,8 @@
 
 char *sid_to_fstring(fstring sidstr_out, const struct dom_sid *sid)
 {
-	dom_sid_string_buf(sid, sidstr_out, sizeof(fstring));
+	struct dom_sid_buf buf;
+	fstrcpy(sidstr_out, dom_sid_str_buf(sid, &buf));
 	return sidstr_out;
 }