From: Harlan Stenn <stenn@ntp.org>
Date: Sat, 5 Dec 2015 10:01:47 +0000 (+0000)
Subject: CID 1341682: Nit in libntp/authreadkeys.c.  HStenn.
X-Git-Tag: NTP_4_3_87~1^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7da8ecce0cf1483cad4568243a5901208f3eca28;p=thirdparty%2Fntp.git

CID 1341682: Nit in libntp/authreadkeys.c.  HStenn.

bk: 5662b60bRrhmXVYfYG8w9OhEYo50-g
---

diff --git a/ChangeLog b/ChangeLog
index 21c8cf7ac..592e0c039 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -10,6 +10,7 @@
 * CID 1341536: Resource leak in tests/ntpd/t-ntp_signd.c.  HStenn.
 * CID 1341537: Resource leak in tests/ntpd/t-ntp_signd.c.  HStenn.
 * CID 1341538: Memory leak in tests/ntpd/ntp_prio_q.c:262.  HStenn.
+* CID 1341682: Nit in libntp/authreadkeys.c.  HStenn.
 * CID 1341684: Nit in tests/ntpd/t-ntp_signd.c.  HStenn.
 * [Bug 2829] Look at pipe_fds in ntpd.c  (did so. perlinger@ntp.org)
 * [Bug 2887] stratum -1 config results as showing value 99
diff --git a/libntp/authreadkeys.c b/libntp/authreadkeys.c
index 5107dd096..95a357a8c 100644
--- a/libntp/authreadkeys.c
+++ b/libntp/authreadkeys.c
@@ -262,10 +262,9 @@ authreadkeys(
 			next->seclen  = len;
 			memcpy(next->secbuf, keystr, len);
 		}
-		if (next) {
-			next->next = list;
-			list = next;
-		}
+		INSIST(NULL != next);
+		next->next = list;
+		list = next;
 	}
 	fclose(fp);
 	if (nerr > nerr_maxlimit) {