From: Javier Miranda <miranda@adacore.com>
Date: Sat, 19 Nov 2022 19:46:31 +0000 (+0000)
Subject: ada: Spurious error on nested call using the prefix notation
X-Git-Tag: basepoints/gcc-14~2693
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7dc44f280e7d1126b4d05e79c53b40df1afe334a;p=thirdparty%2Fgcc.git

ada: Spurious error on nested call using the prefix notation

gcc/ada/

	* exp_ch6.adb
	(Build_Static_Check_Helper_Call): Perform implicit type conversion
	to ensure matching types and avoid reporting spurious errors.
---

diff --git a/gcc/ada/exp_ch6.adb b/gcc/ada/exp_ch6.adb
index 7555bf5dcf5b..c026b63fcf64 100644
--- a/gcc/ada/exp_ch6.adb
+++ b/gcc/ada/exp_ch6.adb
@@ -7552,9 +7552,10 @@ package body Exp_Ch6 is
 
             Remove_Side_Effects (A);
 
-            if Is_Controlling_Actual (A)
-              and then Etype (F) /= Etype (A)
-            then
+            --  Ensure matching types to avoid reporting spurious errors since
+            --  the called helper may have been built for a parent type.
+
+            if Etype (F) /= Etype (A) then
                Append_To (Actuals,
                  Unchecked_Convert_To (Etype (F), New_Copy_Tree (A)));
             else