From: Markus Stockhausen Date: Sun, 3 May 2026 16:42:34 +0000 (+0200) Subject: realtek: mdio: add 10G polling comment X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7dfd33d859aaebc0b000a13202836e032a0d362e;p=thirdparty%2Fopenwrt.git realtek: mdio: add 10G polling comment Make clear that the hardware design always uses the same type of 10G phys. So it is uncritical that the polling values are overwritten multiple times. Signed-off-by: Markus Stockhausen Link: https://github.com/openwrt/openwrt/pull/23204 Signed-off-by: Robert Marko --- diff --git a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c index 6be60c9b42b..9889b62e3eb 100644 --- a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c +++ b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c @@ -792,7 +792,7 @@ static void rtmdio_930x_setup_polling(struct rtmdio_ctrl *ctrl) regmap_assign_bits(ctrl->map, RTMDIO_930X_SMI_PRVTE_POLLING_CTRL, BIT(pn), phyinfo.has_giga_lite); - /* special duplex/advertisement polling registers */ + /* Unique 10G polling setup enforced by hardware design. Always same 10G PHYs. */ if (phyinfo.poll_duplex || phyinfo.poll_adv_1000 || phyinfo.poll_lpa_1000) { regmap_write(ctrl->map, RTMDIO_930X_SMI_10G_POLLING_REG0_CFG, phyinfo.poll_duplex); regmap_write(ctrl->map, RTMDIO_930X_SMI_10G_POLLING_REG9_CFG, phyinfo.poll_adv_1000); @@ -865,7 +865,7 @@ static void rtmdio_931x_setup_polling(struct rtmdio_ctrl *ctrl) regmap_assign_bits(ctrl->map, RTMDIO_931X_SMI_GLB_CTRL1, BIT(smi_bus * 2), phyinfo.force_res); - /* special polling registers */ + /* Unique 10G polling setup enforced by hardware design. Always same 10G PHYs. */ if (phyinfo.poll_duplex || phyinfo.poll_adv_1000 || phyinfo.poll_lpa_1000) { regmap_write(ctrl->map, RTMDIO_931X_SMI_10GPHY_POLLING_SEL2, phyinfo.poll_duplex); regmap_write(ctrl->map, RTMDIO_931X_SMI_10GPHY_POLLING_SEL3, phyinfo.poll_adv_1000);