From: Ralph Boehme Date: Tue, 11 Sep 2018 12:05:43 +0000 (+0200) Subject: vfs_fruit: fix two comments X-Git-Tag: tdb-1.3.17~1361 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e010abbaad79643f31361de47340c218fa39505;p=thirdparty%2Fsamba.git vfs_fruit: fix two comments Thanks to the recent addition of ad_convert_xattr() we now correctly handle this case. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649 Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison --- diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c index 894c361a05f..65d6618ff2d 100644 --- a/source3/modules/vfs_fruit.c +++ b/source3/modules/vfs_fruit.c @@ -1055,8 +1055,7 @@ static bool ad_convert_xattr(struct adouble *ad, * Convert from Apple's ._ file to Netatalk * * Apple's AppleDouble may contain a FinderInfo entry longer then 32 - * bytes containing packed xattrs. Netatalk can't deal with that, so - * we simply discard the packed xattrs. + * bytes containing packed xattrs. * * @return -1 in case an error occurred, 0 if no conversion was done, 1 * otherwise @@ -1374,9 +1373,7 @@ static ssize_t ad_read_rsrc_adouble(struct adouble *ad, /* * Try to fixup AppleDouble files created by OS X with xattrs - * appended to the ADEID_FINDERI entry. We simply remove the - * xattrs blob, this means any fancy xattr that was stored - * there is lost. + * appended to the ADEID_FINDERI entry. */ ret = ad_convert(ad, smb_fname, ad->ad_fd);