From: Andreas Schwab <schwab@linux-m68k.org>
Date: Wed, 4 Apr 2012 13:06:17 +0000 (+0200)
Subject: tests: avoid unnecessary subshells in misc/stty
X-Git-Tag: v8.17~38
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e0ef7c035a4ef331dfd5019465ad00171a7b800;p=thirdparty%2Fcoreutils.git

tests: avoid unnecessary subshells in misc/stty

* tests/misc/stty: Don't waste a subshell to perform this:
eval rev=\$REV_$opt.  Fix rev1,rev2 assignments similarly.
---

diff --git a/tests/misc/stty b/tests/misc/stty
index 97020e8fee..1b082c2b88 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -70,7 +70,7 @@ for opt in $options; do
 
   # Likewise, 'stty -cread' would fail, so skip that, too.
   test $opt = cread && continue
-  rev=$(eval echo "\$REV_$opt")
+  eval rev=\$REV_$opt
   if test -n "$rev"; then
     stty -$opt || { fail=1; echo -$opt; }
   fi
@@ -84,8 +84,8 @@ if test -n "$RUN_LONG_TESTS"; then
 
       stty $opt1 $opt2 || fail=1
 
-      rev1=$(eval echo "\$REV_$opt1")
-      rev2=$(eval echo "\$REV_$opt2")
+      eval rev1=\$REV_$opt1
+      eval rev2=\$REV_$opt2
       if test -n "$rev1"; then
         stty -$opt1 $opt2 || fail=1
       fi