From: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
Date: Wed, 27 Sep 2017 08:53:50 +0000 (+0800)
Subject: nwfilter: Fix memory leak in virNWFilterIPAddrMapAddIPAddr
X-Git-Tag: v3.8.0-rc1~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e2086257602a4726e7affd2806f4f984ea6287d;p=thirdparty%2Flibvirt.git

nwfilter: Fix memory leak in virNWFilterIPAddrMapAddIPAddr

If virNWFilterHashTablePut fails, then the @val was leaked.

Signed-off-by: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
---

diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c
index 446f3de4f9..9c8584ce27 100644
--- a/src/conf/nwfilter_ipaddrmap.c
+++ b/src/conf/nwfilter_ipaddrmap.c
@@ -61,6 +61,8 @@ virNWFilterIPAddrMapAddIPAddr(const char *ifname, char *addr)
         if (!val)
             goto cleanup;
         ret = virNWFilterHashTablePut(ipAddressMap, ifname, val);
+        if (ret < 0)
+            virNWFilterVarValueFree(val);
         goto cleanup;
     } else {
         if (virNWFilterVarValueAddValue(val, addr) < 0)