From: Igor Ustinov Date: Thu, 27 Nov 2025 07:56:45 +0000 (+0100) Subject: Branch 3.2 was removed from the "Provider compatibility across versions" X-Git-Tag: 4.0-PRE-CLANG-FORMAT-WEBKIT~117 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e430d9dc1857da2e9fd173a6060737be5d4a06a;p=thirdparty%2Fopenssl.git Branch 3.2 was removed from the "Provider compatibility across versions" test and "skip the same version" logic was changed. Reviewed-by: Tomas Mraz Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/29236) --- diff --git a/.github/workflows/provider-compatibility.yml b/.github/workflows/provider-compatibility.yml index c199d5e8a24..290c2751ad0 100644 --- a/.github/workflows/provider-compatibility.yml +++ b/.github/workflows/provider-compatibility.yml @@ -119,11 +119,6 @@ jobs: dir: branch-3.0, tgz: branch-3.0.tar.gz, extra_config: "", - }, { - name: openssl-3.2, - dir: branch-3.2, - tgz: branch-3.2.tar.gz, - extra_config: "", }, { name: openssl-3.3, dir: branch-3.3, @@ -219,46 +214,46 @@ jobs: # later providers. Problems in these situations ought to be # caught by cross branch testing before the release. tree_a: [ branch-master, branch-3.6, branch-3.5, branch-3.4, branch-3.3, - branch-3.2, branch-3.0, + branch-3.0, openssl-3.0.0, openssl-3.0.8, openssl-3.0.9, openssl-3.1.2 ] tree_b: [ branch-master, branch-3.6, branch-3.5, branch-3.4, branch-3.3, - branch-3.2, branch-3.0 ] + branch-3.0 ] steps: - name: early exit checks id: early_exit run: | - if [ "${{ matrix.tree_a }}" = "${{ matrix.tree_b }}" ]; \ - then \ - echo "Skipping because both are the same version"; \ - exit 1; \ + if [ "${{ matrix.tree_a }}" = "${{ matrix.tree_b }}" ]; then + echo "Skipping because both are the same version" + echo "skip=true" >> "$GITHUB_OUTPUT" + else + echo "skip=false" >> "$GITHUB_OUTPUT" fi - continue-on-error: true - uses: actions/download-artifact@v6.0.0 - if: steps.early_exit.outcome == 'success' + if: steps.early_exit.outputs.skip != 'true' with: name: ${{ matrix.tree_a }}.tar.gz - name: unpack first build - if: steps.early_exit.outcome == 'success' + if: steps.early_exit.outputs.skip != 'true' run: tar xzf "${{ matrix.tree_a }}.tar.gz" - uses: actions/download-artifact@v6.0.0 - if: steps.early_exit.outcome == 'success' + if: steps.early_exit.outputs.skip != 'true' with: name: ${{ matrix.tree_b }}.tar.gz - name: unpack second build - if: steps.early_exit.outcome == 'success' + if: steps.early_exit.outputs.skip != 'true' run: tar xzf "${{ matrix.tree_b }}.tar.gz" - name: set up cross validation of FIPS from A with tree from B - if: steps.early_exit.outcome == 'success' + if: steps.early_exit.outputs.skip != 'true' run: | cp providers/fips.so ../${{ matrix.tree_b }}/providers/ cp providers/fipsmodule.cnf ../${{ matrix.tree_b }}/providers/ working-directory: ${{ matrix.tree_a }} - name: show module versions from cross validation - if: steps.early_exit.outcome == 'success' + if: steps.early_exit.outputs.skip != 'true' run: | ./util/wrap.pl -fips apps/openssl list -provider-path providers \ -provider base \ @@ -269,14 +264,14 @@ jobs: working-directory: ${{ matrix.tree_b }} - name: get cpu info - if: steps.early_exit.outcome == 'success' + if: steps.early_exit.outputs.skip != 'true' run: | cat /proc/cpuinfo ./util/opensslwrap.sh version -c working-directory: ${{ matrix.tree_b }} - name: run cross validation tests of FIPS from A with tree from B - if: steps.early_exit.outcome == 'success' + if: steps.early_exit.outputs.skip != 'true' run: | make test HARNESS_JOBS=${HARNESS_JOBS:-4} working-directory: ${{ matrix.tree_b }}