From: Jeremy Allison <jra@samba.org>
Date: Thu, 18 Jun 2009 09:53:52 +0000 (+0200)
Subject: Fix bug #6476 - more then 3000 smbd-zombies in memory
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e51314f2e18241876b049642fcb133df7e44c70;p=thirdparty%2Fsamba.git

Fix bug #6476 - more then 3000 smbd-zombies in memory

We weren't reaping children in the [x]inetd case.

Jeremy.
---

diff --git a/source/smbd/server.c b/source/smbd/server.c
index 2415aebabc3..e0f86a6b7ca 100644
--- a/source/smbd/server.c
+++ b/source/smbd/server.c
@@ -355,10 +355,6 @@ static bool open_sockets_smbd(bool is_daemon, bool interactive, const char *smb_
 	struct dns_reg_state * dns_reg = NULL;
 	unsigned dns_port = 0;
 
-	if (!is_daemon) {
-		return open_sockets_inetd();
-	}
-
 #ifdef HAVE_ATEXIT
 	{
 		static int atexit_set;
@@ -369,6 +365,17 @@ static bool open_sockets_smbd(bool is_daemon, bool interactive, const char *smb_
 	}
 #endif
 
+	if (!is_daemon) {
+		/*
+		 * Stop zombies the old way.
+		 * We aren't forking any new
+		 * 'normal' connections when
+		 * run from [x]inetd.
+		 */
+		CatchChild();
+		return open_sockets_inetd();
+	}
+
 	/* Stop zombies */
 	CatchSignal(SIGCLD, sig_cld);
 
@@ -1252,6 +1259,10 @@ extern void build_options(bool screen);
 	BlockSignals(False, SIGUSR1);
 	BlockSignals(False, SIGTERM);
 
+        /* Ensure we leave no zombies until we
+	 * correctly set up child handling below. */
+        CatchChild();
+
 	/* we want total control over the permissions on created files,
 	   so set our umask to 0 */
 	umask(0);