From: Volker Lendecke <vl@samba.org>
Date: Tue, 9 Jun 2020 14:15:46 +0000 (+0200)
Subject: libcli: Slightly simplify smb2cli_req_recv() with an early return
X-Git-Tag: ldb-2.2.0~113
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e73527ad3523efa4ce24e92a2cd194b59967852;p=thirdparty%2Fsamba.git

libcli: Slightly simplify smb2cli_req_recv() with an early return

One if-condition less

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index 895fa64fcf5..3e5bee92ed1 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -4012,15 +4012,10 @@ NTSTATUS smb2cli_req_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
 	if (tevent_req_is_nterror(req, &status)) {
 		for (i=0; i < num_expected; i++) {
 			if (NT_STATUS_EQUAL(status, expected[i].status)) {
-				found_status = true;
-				break;
+				return NT_STATUS_UNEXPECTED_NETWORK_ERROR;
 			}
 		}
 
-		if (found_status) {
-			return NT_STATUS_UNEXPECTED_NETWORK_ERROR;
-		}
-
 		return status;
 	}