From: Sabrina Dubroca Date: Mon, 14 Jul 2025 14:20:02 +0000 (+0200) Subject: ovpn: use correct array size to parse nested attributes in ovpn_nl_key_swap_doit X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e7ca01d912637316c0159a0a15a5fc14cd12aff;p=thirdparty%2Flinux.git ovpn: use correct array size to parse nested attributes in ovpn_nl_key_swap_doit In ovpn_nl_key_swap_doit, the attributes array used to parse the OVPN_A_KEYCONF uses OVPN_A_PEER_MAX instead of OVPN_A_KEYCONF_MAX. Note that this does not cause any bug, since currently OVPN_A_KEYCONF_MAX < OVPN_A_PEER_MAX. The wrong constant was introduced by commit 203e2bf55990 ("ovpn: implement key add/get/del/swap via netlink") Signed-off-by: Sabrina Dubroca Signed-off-by: Antonio Quartulli --- diff --git a/drivers/net/ovpn/netlink.c b/drivers/net/ovpn/netlink.c index c7f3824376302..fed0e46b32a33 100644 --- a/drivers/net/ovpn/netlink.c +++ b/drivers/net/ovpn/netlink.c @@ -1061,8 +1061,8 @@ err: int ovpn_nl_key_swap_doit(struct sk_buff *skb, struct genl_info *info) { + struct nlattr *attrs[OVPN_A_KEYCONF_MAX + 1]; struct ovpn_priv *ovpn = info->user_ptr[0]; - struct nlattr *attrs[OVPN_A_PEER_MAX + 1]; struct ovpn_peer *peer; u32 peer_id; int ret;