From: Francis Dupont <fdupont@isc.org>
Date: Tue, 7 Mar 2017 10:45:23 +0000 (+0100)
Subject: [fdunparse2] Finished agent and added some @todos
X-Git-Tag: trac5152_base~3^2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e81bfc698cc83b24bdd8db1a3d78873181e1710;p=thirdparty%2Fkea.git

[fdunparse2] Finished agent and added some @todos
---

diff --git a/src/bin/agent/tests/testdata/get_config.json b/src/bin/agent/tests/testdata/get_config.json
index b52f7910bf..3c264b0354 100644
--- a/src/bin/agent/tests/testdata/get_config.json
+++ b/src/bin/agent/tests/testdata/get_config.json
@@ -16,7 +16,7 @@
         },
         "hooks-libraries": [
             {
-                "library": "/tmp/kea/src/bin/agent/tests/.libs/libbasic.so",
+                "library": "/opt/local/control-agent-commands.so",
                 "parameters": {
                     "param1": "foo"
                 }
diff --git a/src/lib/dhcpsrv/cfg_mac_source.cc b/src/lib/dhcpsrv/cfg_mac_source.cc
index 9475f6e14d..7a0db260b3 100644
--- a/src/lib/dhcpsrv/cfg_mac_source.cc
+++ b/src/lib/dhcpsrv/cfg_mac_source.cc
@@ -81,6 +81,7 @@ ElementPtr CfgMACSource::toElement() const {
         }
         result->add(Element::create(name));
     }
+    // @todo check if the list is empty (including a new unit test)
     return (result);
 }
 
diff --git a/src/lib/dhcpsrv/cfg_subnets4.cc b/src/lib/dhcpsrv/cfg_subnets4.cc
index 425c5faa0b..14f1c15be6 100644
--- a/src/lib/dhcpsrv/cfg_subnets4.cc
+++ b/src/lib/dhcpsrv/cfg_subnets4.cc
@@ -313,7 +313,7 @@ CfgSubnets4::toElement() const {
         ElementPtr pool_list = Element::createList();
         for (PoolCollection::const_iterator pool = pools.cbegin();
              pool != pools.cend(); ++pool) {
-            // Prepare the map for a pool
+            // Prepare the map for a pool (@todo move this code to pool.cc)
             ElementPtr pool_map = Element::createMap();
             // Set pool
             const IOAddress& first = (*pool)->getFirstAddress();
diff --git a/src/lib/dhcpsrv/cfg_subnets6.cc b/src/lib/dhcpsrv/cfg_subnets6.cc
index 2407976bdb..c2c8c5f165 100644
--- a/src/lib/dhcpsrv/cfg_subnets6.cc
+++ b/src/lib/dhcpsrv/cfg_subnets6.cc
@@ -289,7 +289,7 @@ CfgSubnets6::toElement() const {
         ElementPtr pool_list = Element::createList();
         for (PoolCollection::const_iterator pool = pools.cbegin();
              pool != pools.cend(); ++pool) {
-            // Prepare the map for a pool
+            // Prepare the map for a pool (@todo move this code to pool.cc)
             ElementPtr pool_map = Element::createMap();
             // Set pool
             const IOAddress& first = (*pool)->getFirstAddress();
@@ -320,7 +320,7 @@ CfgSubnets6::toElement() const {
         ElementPtr pdpool_list = Element::createList();
         for (PoolCollection::const_iterator pool = pdpools.cbegin();
              pool != pdpools.cend(); ++pool) {
-            // Get it as a Pool6
+            // Get it as a Pool6 (@todo move this code to pool.cc)
             const Pool6* pdpool = dynamic_cast<Pool6*>(pool->get());
             if (!pdpool) {
                 isc_throw(ToElementError, "invalid pd-pool pointer");