From: Rakesh Pandit Date: Fri, 23 Aug 2019 02:53:46 +0000 (-0400) Subject: ext4: fix warning inside ext4_convert_unwritten_extents_endio X-Git-Tag: v3.16.79~56 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e89264eddda40ada74c75e440b96d112e0453e3;p=thirdparty%2Fkernel%2Fstable.git ext4: fix warning inside ext4_convert_unwritten_extents_endio commit e3d550c2c4f2f3dba469bc3c4b83d9332b4e99e1 upstream. Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing first argument. This was introduced in commit ff95ec22cd7f ("ext4: add warning to ext4_convert_unwritten_extents_endio") and splitting extents inside endio would trigger it. Fixes: ff95ec22cd7f ("ext4: add warning to ext4_convert_unwritten_extents_endio") Signed-off-by: Rakesh Pandit Signed-off-by: Theodore Ts'o Signed-off-by: Ben Hutchings --- diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 3bb1153827d84..25620fc51bf39 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -3775,8 +3775,8 @@ static int ext4_convert_unwritten_extents_endio(handle_t *handle, * illegal. */ if (ee_block != map->m_lblk || ee_len > map->m_len) { -#ifdef EXT4_DEBUG - ext4_warning("Inode (%ld) finished: extent logical block %llu," +#ifdef CONFIG_EXT4_DEBUG + ext4_warning(inode->i_sb, "Inode (%ld) finished: extent logical block %llu," " len %u; IO logical block %llu, len %u\n", inode->i_ino, (unsigned long long)ee_block, ee_len, (unsigned long long)map->m_lblk, map->m_len);