From: lpsolit%gmail.com <>
Date: Tue, 28 Nov 2006 02:21:46 +0000 (+0000)
Subject: Bug 361875: Use of uninitialized value in numeric eq (==) at Bugzilla/User.pm line... 
X-Git-Tag: bugzilla-2.23.4~175
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e97a6c2f0b9ed01dbda9d47194acaf043fbed75;p=thirdparty%2Fbugzilla.git

Bug 361875: Use of uninitialized value in numeric eq (==) at Bugzilla/User.pm line 1465 - Patch by Frédéric Buclin <LpSolit@gmail.com> r=bkor a=justdave
---

diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index 3c18f19082..05b96dd29f 100644
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -1461,16 +1461,16 @@ sub wants_mail {
     # No mail if there are no events
     return 0 if !scalar(@$events);
 
-    # Skip DB query if relationship is explicit
-    return 1 if $relationship == REL_GLOBAL_WATCHER;
-    
-    my $dbh = Bugzilla->dbh;
-    
     # If a relationship isn't given, default to REL_ANY.
     if (!defined($relationship)) {
         $relationship = REL_ANY;
     }
-    
+
+    # Skip DB query if relationship is explicit
+    return 1 if $relationship == REL_GLOBAL_WATCHER;
+
+    my $dbh = Bugzilla->dbh;
+
     my $wants_mail = 
         $dbh->selectrow_array('SELECT 1
                                  FROM email_setting