From: Luis Machado <luis.machado@arm.com>
Date: Fri, 22 Jul 2022 10:22:29 +0000 (+0100)
Subject: [Morello GDB] Fix bug in conditional definition of morello structs
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7eb2ec2ab2f8a62f96728fd7946b39ade4acb2eb;p=thirdparty%2Fbinutils-gdb.git

[Morello GDB] Fix bug in conditional definition of morello structs

The previous commit fixing this issue (bf5ddcecc07c2d89e824851f5f940ebe7e2af0fd)
failed to spot an issue with include ordering.

Fix all such issues with this patch.
---

diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
index 4ca2e373851..476a2d1e3b2 100644
--- a/gdb/aarch64-linux-nat.c
+++ b/gdb/aarch64-linux-nat.c
@@ -34,10 +34,6 @@
 #include "aarch32-tdep.h"
 #include "arch/arm.h"
 #include "arch/aarch64-cap-linux.h"
-#include "nat/aarch64-cap-linux.h"  /* For Morello */
-#include "nat/aarch64-linux.h"
-#include "nat/aarch64-linux-hw-point.h"
-#include "nat/aarch64-sve-linux-ptrace.h"
 
 #include "elf/external.h"
 #include "elf/common.h"
@@ -57,6 +53,11 @@
 
 #include "nat/aarch64-mte-linux-ptrace.h"
 
+#include "nat/aarch64-cap-linux.h"  /* For Morello */
+#include "nat/aarch64-linux.h"
+#include "nat/aarch64-linux-hw-point.h"
+#include "nat/aarch64-sve-linux-ptrace.h"
+
 #ifndef TRAP_HWBKPT
 #define TRAP_HWBKPT 0x0004
 #endif
diff --git a/gdb/nat/aarch64-cap-linux.c b/gdb/nat/aarch64-cap-linux.c
index 34aa5ec1ac0..62a4dcdff72 100644
--- a/gdb/nat/aarch64-cap-linux.c
+++ b/gdb/nat/aarch64-cap-linux.c
@@ -16,8 +16,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "gdbsupport/common-defs.h"
-#include "aarch64-cap-linux.h"
 #include "gdb_ptrace.h"
+#include "aarch64-cap-linux.h"
 
 /* Helper function to display various possible errors when reading
    Morello capabilities from memory.  */
diff --git a/gdbserver/linux-aarch64-low.cc b/gdbserver/linux-aarch64-low.cc
index cf36cbe71ab..8013edf0459 100644
--- a/gdbserver/linux-aarch64-low.cc
+++ b/gdbserver/linux-aarch64-low.cc
@@ -21,9 +21,6 @@
 
 #include "server.h"
 #include "linux-low.h"
-#include "nat/aarch64-cap-linux.h" /* For Morello  */
-#include "nat/aarch64-linux.h"
-#include "nat/aarch64-linux-hw-point.h"
 #include "arch/aarch64-cap-linux.h"
 #include "arch/aarch64-insn.h"
 #include "linux-aarch32-low.h"
@@ -47,6 +44,10 @@
 #include "linux-aarch64-tdesc.h"
 #include "nat/aarch64-mte-linux-ptrace.h"
 #include "nat/aarch64-sve-linux-ptrace.h"
+#include "nat/aarch64-cap-linux.h" /* For Morello  */
+#include "nat/aarch64-linux.h"
+#include "nat/aarch64-linux-hw-point.h"
+
 #include "tdesc.h"
 
 #ifdef HAVE_SYS_REG_H