From: Sander Steffann <sander@steffann.nl>
Date: Tue, 20 Jul 2021 10:50:19 +0000 (+0200)
Subject: Document setTag(Response)Action behaviour
X-Git-Tag: dnsdist-1.7.0-alpha1~75^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7eb5fc105788bda9ab9733bdf34ddd1cc77283a5;p=thirdparty%2Fpdns.git

Document setTag(Response)Action behaviour

Explicitly document that setTagAction and setTagResponseAction do not overwrite existing tag values.
---

diff --git a/pdns/dnsdistdist/docs/rules-actions.rst b/pdns/dnsdistdist/docs/rules-actions.rst
index 835d996315..2b9d78b651 100644
--- a/pdns/dnsdistdist/docs/rules-actions.rst
+++ b/pdns/dnsdistdist/docs/rules-actions.rst
@@ -1334,6 +1334,7 @@ The following actions exist.
   .. versionadded:: 1.6.0
 
   Associate a tag named ``name`` with a value of ``value`` to this query, that will be passed on to the response.
+  This function will not overwrite an existing tag. If the tag already exists it will keep its original value.
   Subsequent rules are processed after this action.
   Note that this function was called :func:`TagAction` before 1.6.0.
 
@@ -1345,6 +1346,7 @@ The following actions exist.
   .. versionadded:: 1.6.0
 
   Associate a tag named ``name`` with a value of ``value`` to this response.
+  This function will not overwrite an existing tag. If the tag already exists it will keep its original value.
   Subsequent rules are processed after this action.
   Note that this function was called :func:`TagResponseAction` before 1.6.0.