From: Stefan Fritsch <sf@apache.org>
Date: Sat, 27 Nov 2010 23:46:57 +0000 (+0000)
Subject: Fix segfault on parse error
X-Git-Tag: 2.3.10~157
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7ec578bc10e8af94f41e4a78f9f0a772147516b0;p=thirdparty%2Fapache%2Fhttpd.git

Fix segfault on parse error


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1039789 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/metadata/mod_setenvif.c b/modules/metadata/mod_setenvif.c
index aa8db0b40ca..5a3cac27207 100644
--- a/modules/metadata/mod_setenvif.c
+++ b/modules/metadata/mod_setenvif.c
@@ -480,10 +480,10 @@ static const char *add_setenvifexpr(cmd_parms *cmd, void *mconfig,
     new->pattern = NULL;
     new->preg = NULL;
     new->expr = ap_expr_parse_cmd(cmd, expr, &err, NULL);
-    new->expr->module_index = setenvif_module.module_index;
     if (err)
         return apr_psprintf(cmd->pool, "Could not parse expression \"%s\": %s",
                             expr, err);
+    new->expr->module_index = setenvif_module.module_index;
 
     return add_envvars(cmd, args, new);
 }