From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Sun, 21 Feb 2021 18:57:31 +0000 (+0100)
Subject: cgroups: skip and warn about invalid file descriptors
X-Git-Tag: lxc-5.0.0~273^2~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7f02fd24f726d0f01b4946415fdb91ec906d17ea;p=thirdparty%2Flxc.git

cgroups: skip and warn about invalid file descriptors

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/cgroups/cgfsng.c b/src/lxc/cgroups/cgfsng.c
index 2ac1b7bba..3632d788f 100644
--- a/src/lxc/cgroups/cgfsng.c
+++ b/src/lxc/cgroups/cgfsng.c
@@ -1305,6 +1305,9 @@ static int chown_cgroup_wrapper(void *data)
 	for (int i = 0; arg->hierarchies[i]; i++) {
 		int dirfd = arg->hierarchies[i]->dfd_con;
 
+		if (dirfd < 0)
+			return syserrno_set(-EBADF, "Invalid cgroup file descriptor");
+
 		(void)fchowmodat(dirfd, "", destuid, nsgid, 0775);
 
 		/*