From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Fri, 7 Aug 2020 16:32:50 +0000 (-0400)
Subject: Include bulk update/delete in RoutingSession example
X-Git-Tag: rel_1_4_0b1~191
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7f52c10357cbc98e467f317128b3fea2018eaf7c;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Include bulk update/delete in RoutingSession example

Fixes: #5407
Change-Id: Ia0965dbc88d744cded5c23021898388f2cf95f8d
---

diff --git a/doc/build/orm/persistence_techniques.rst b/doc/build/orm/persistence_techniques.rst
index 226b318373..ffafe92958 100644
--- a/doc/build/orm/persistence_techniques.rst
+++ b/doc/build/orm/persistence_techniques.rst
@@ -706,7 +706,8 @@ More comprehensive rule-based class-level partitioning can be built by
 overriding the :meth:`.Session.get_bind` method.   Below we illustrate
 a custom :class:`.Session` which delivers the following rules:
 
-1. Flush operations are delivered to the engine named ``leader``.
+1. Flush operations, as well as bulk "update" and "delete" operations,
+   are delivered to the engine named ``leader``.
 
 2. Operations on objects that subclass ``MyOtherClass`` all
    occur on the ``other`` engine.
@@ -723,6 +724,7 @@ a custom :class:`.Session` which delivers the following rules:
         'follower2':create_engine("sqlite:///follower2.db"),
     }
 
+    from sqlalchemy.sql import Update, Delete
     from sqlalchemy.orm import Session, sessionmaker
     import random
 
@@ -730,7 +732,7 @@ a custom :class:`.Session` which delivers the following rules:
         def get_bind(self, mapper=None, clause=None):
             if mapper and issubclass(mapper.class_, MyOtherClass):
                 return engines['other']
-            elif self._flushing:
+            elif self._flushing or isinstance(clause, (Update, Delete)):
                 return engines['leader']
             else:
                 return engines[