From: Krzysztof Kozlowski Date: Mon, 3 Nov 2014 14:07:05 +0000 (+0100) Subject: regulator: max77693: Fix use of uninitialized regulator config X-Git-Tag: v3.12.33~8 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7f7ae192a6d6472d06a2d5a05daba04ce9facc43;p=thirdparty%2Fkernel%2Fstable.git regulator: max77693: Fix use of uninitialized regulator config commit ca0c37a0b489bb14bf3e1549e7a8d0c9a17f4919 upstream. Driver allocated on stack struct regulator_config but didn't initialize it fully. Few fields (driver_data, ena_gpio) were left untouched. This lead to using random ena_gpio values as GPIOs for max77693 regulators. On occasion these values could match real GPIO numbers leading to interfering with other drivers and to unsuccessful enable/disable of regulator. Signed-off-by: Krzysztof Kozlowski Fixes: 80b022e29bfd ("regulator: max77693: Add max77693 regualtor driver.") Signed-off-by: Mark Brown Signed-off-by: Jiri Slaby --- diff --git a/drivers/regulator/max77693.c b/drivers/regulator/max77693.c index ce4b96c15ebaa..85a54b39e3b71 100644 --- a/drivers/regulator/max77693.c +++ b/drivers/regulator/max77693.c @@ -231,7 +231,7 @@ static int max77693_pmic_probe(struct platform_device *pdev) struct max77693_pmic_dev *max77693_pmic; struct max77693_regulator_data *rdata = NULL; int num_rdata, i, ret; - struct regulator_config config; + struct regulator_config config = { }; num_rdata = max77693_pmic_init_rdata(&pdev->dev, &rdata); if (!rdata || num_rdata <= 0) {