From: Michael Brown <mcb30@ipxe.org>
Date: Wed, 11 Mar 2015 22:33:51 +0000 (+0000)
Subject: [smsc75xx] Move RX FIFO overflow message to DBGLVL_EXTRA
X-Git-Tag: v1.20.1~901
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7f80eb511e9bbbf74de56d110f351f0b1b052d76;p=thirdparty%2Fipxe.git

[smsc75xx] Move RX FIFO overflow message to DBGLVL_EXTRA

RX FIFO overflow is almost inevitable since the (usable) USB2 bus
bandwidth is approximately one quarter of the Ethernet bandwidth.
Avoid flooding the console with RX FIFO overflow messages in a
standard debug build.

With TCP SACK implemented, the RX FIFO overflow no longer causes a
catastrophic drop in throughput.  Experimentation shows that HTTP
downloads now progress at a fairly smooth 250Mbps, which is around the
maximum speed attainable for a USB2 NIC.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/drivers/net/smsc75xx.c b/src/drivers/net/smsc75xx.c
index c6328517f..017e02a59 100644
--- a/src/drivers/net/smsc75xx.c
+++ b/src/drivers/net/smsc75xx.c
@@ -915,7 +915,8 @@ static void smsc75xx_poll ( struct net_device *netdev ) {
 
 	/* Record RX FIFO overflow if applicable */
 	if ( int_sts & SMSC75XX_INT_STS_RDFO_INT ) {
-		DBGC ( smsc75xx, "SMSC75XX %p RX FIFO overflowed\n", smsc75xx );
+		DBGC2 ( smsc75xx, "SMSC75XX %p RX FIFO overflowed\n",
+			smsc75xx );
 		netdev_rx_err ( netdev, NULL, -ENOBUFS );
 		int_sts &= ~SMSC75XX_INT_STS_RDFO_INT;
 	}