From: Shivani Bhardwaj <shivani@oisf.net>
Date: Thu, 1 Feb 2024 11:28:48 +0000 (+0530)
Subject: detect: remove unneeded max_idx
X-Git-Tag: suricata-8.0.0-beta1~1799
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7f89aaf772e65bc289528b59a7aee166c7c84f43;p=thirdparty%2Fsuricata.git

detect: remove unneeded max_idx
---

diff --git a/src/detect-engine-build.c b/src/detect-engine-build.c
index b99776bd13..0c07150e69 100644
--- a/src/detect-engine-build.c
+++ b/src/detect-engine-build.c
@@ -960,7 +960,6 @@ static int RulesGroupByProto(DetectEngineCtx *de_ctx)
 {
     Signature *s = de_ctx->sig_list;
 
-    uint32_t max_idx = 0;
     SigGroupHead *sgh_ts[256] = {NULL};
     SigGroupHead *sgh_tc[256] = {NULL};
 
@@ -979,15 +978,12 @@ static int RulesGroupByProto(DetectEngineCtx *de_ctx)
 
             if (s->flags & SIG_FLAG_TOCLIENT) {
                 SigGroupHeadAppendSig(de_ctx, &sgh_tc[p], s);
-                max_idx = s->num;
             }
             if (s->flags & SIG_FLAG_TOSERVER) {
                 SigGroupHeadAppendSig(de_ctx, &sgh_ts[p], s);
-                max_idx = s->num;
             }
         }
     }
-    SCLogDebug("max_idx %u", max_idx);
 
     /* lets look at deduplicating this list */
     SigGroupHeadHashFree(de_ctx);
@@ -1140,7 +1136,6 @@ static DetectPort *RulesGroupByPorts(DetectEngineCtx *de_ctx, uint8_t ipproto, u
      *         that belong to the SGH. */
     DetectPortHashInit(de_ctx);
 
-    uint32_t max_idx = 0;
     const Signature *s = de_ctx->sig_list;
     DetectPort *list = NULL;
     while (s) {
@@ -1199,7 +1194,6 @@ static DetectPort *RulesGroupByPorts(DetectEngineCtx *de_ctx, uint8_t ipproto, u
 
             p = p->next;
         }
-        max_idx = s->num;
     next:
         s = s->next;
     }