From: bbaetz%student.usyd.edu.au <>
Date: Tue, 5 Feb 2002 08:11:48 +0000 (+0000)
Subject: Bug 122418 pt2 - obsoleting a patch from the create attachment screen gave
X-Git-Tag: bugzilla-2.16rc1~243
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7fa045d01faf68f35814861d4c13ab8a7127c0d4;p=thirdparty%2Fbugzilla.git

Bug 122418 pt2 - obsoleting a patch from the create attachment screen gave
a taint error.
---

diff --git a/attachment.cgi b/attachment.cgi
index 368ad702e2..f58844835b 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -314,7 +314,7 @@ sub validateObsolete
   # Make sure the attachment id is valid and the user has permissions to view
   # the bug to which it is attached.
   foreach my $attachid (@{$::MFORM{'obsolete'}}) {
-    $attachid =~ /^[1-9][0-9]*$/
+    detaint_natural($attachid)
       || DisplayError("The attachment number of one of the attachments 
            you wanted to obsolete is invalid.") 
         && exit;