From: Philippe Antoine <pantoine@oisf.net>
Date: Tue, 15 Apr 2025 10:38:34 +0000 (+0200)
Subject: http2: do not set file flags for global txs
X-Git-Tag: suricata-7.0.11~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7fa88ea9e7d05e07a7864050cfd836b576669720;p=thirdparty%2Fsuricata.git

http2: do not set file flags for global txs

Global txs means here txs with stream id 0, used for connection control
messages.

(cherry picked from commit fa8d3a4ccb17f84ccc577069a941a589b6e3906c)
---

diff --git a/rust/src/http2/http2.rs b/rust/src/http2/http2.rs
index 8aa21189a8..3994ce698a 100644
--- a/rust/src/http2/http2.rs
+++ b/rust/src/http2/http2.rs
@@ -602,10 +602,7 @@ impl HTTP2State {
         self.tx_id += 1;
         tx.tx_id = self.tx_id;
         tx.state = HTTP2TransactionState::HTTP2StateGlobal;
-        tx.tx_data.update_file_flags(self.state_data.file_flags);
-        // TODO can this tx hold files?
-        tx.tx_data.file_tx = STREAM_TOSERVER|STREAM_TOCLIENT; // might hold files in both directions
-        tx.update_file_flags(tx.tx_data.file_flags);
+        // a global tx (stream id 0) does not hold files cf RFC 9113 section 5.1.1
         self.transactions.push_back(tx);
         return self.transactions.back_mut().unwrap();
     }