From: Norbert Pocs <norbertp@openssl.org>
Date: Sun, 5 Oct 2025 07:39:22 +0000 (+0200)
Subject: Check return code of BIO_ADDR_rawaddress
X-Git-Tag: 4.0-PRE-CLANG-FORMAT-WEBKIT~393
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7fb9163586234ed9eecf95ae2fd7185a9dcb556e;p=thirdparty%2Fopenssl.git

Check return code of BIO_ADDR_rawaddress

Fixes coverity issue: https://scan5.scan.coverity.com/#/project-view/64471/10222?selectedIssue=1666584
Thank you for the report!

Signed-off-by: Norbert Pocs <norbertp@openssl.org>

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/28751)
---

diff --git a/apps/lib/s_cb.c b/apps/lib/s_cb.c
index 496cb3c6f16..b567b179b68 100644
--- a/apps/lib/s_cb.c
+++ b/apps/lib/s_cb.c
@@ -894,7 +894,8 @@ int generate_stateless_cookie_callback(SSL *ssl, unsigned char *cookie,
     buffer = app_malloc(length, "cookie generate buffer");
 
     memcpy(buffer, &port, sizeof(port));
-    BIO_ADDR_rawaddress(peer, buffer + sizeof(port), NULL);
+    if (!BIO_ADDR_rawaddress(peer, buffer + sizeof(port), NULL))
+        goto end;
 
     if (EVP_Q_mac(NULL, "HMAC", NULL, "SHA1", NULL,
                   cookie_secret, COOKIE_SECRET_LENGTH, buffer, length,