From: Ján Tomko <jtomko@redhat.com>
Date: Tue, 13 Aug 2019 13:11:14 +0000 (+0200)
Subject: util: introduce readonly attribute to virPCIDeviceConfigOpenInternal
X-Git-Tag: v5.7.0-rc1~232
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=801ebb5edb67c78cb63eddd93068e4e451d69839;p=thirdparty%2Flibvirt.git

util: introduce readonly attribute to virPCIDeviceConfigOpenInternal

Allow wrappers to open PCI config as read-only.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/util/virpci.c b/src/util/virpci.c
index c1dad1e69f..e45dfbc631 100644
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -291,11 +291,11 @@ virPCIDeviceGetDriverPathAndName(virPCIDevicePtr dev, char **path, char **name)
 
 
 static int
-virPCIDeviceConfigOpenInternal(virPCIDevicePtr dev, bool fatal)
+virPCIDeviceConfigOpenInternal(virPCIDevicePtr dev, bool readonly, bool fatal)
 {
     int fd;
 
-    fd = open(dev->path, O_RDWR);
+    fd = open(dev->path, readonly ? O_RDONLY : O_RDWR);
 
     if (fd < 0) {
         if (fatal) {
@@ -317,13 +317,13 @@ virPCIDeviceConfigOpenInternal(virPCIDevicePtr dev, bool fatal)
 static int
 virPCIDeviceConfigOpen(virPCIDevicePtr dev, bool fatal)
 {
-    return virPCIDeviceConfigOpenInternal(dev, fatal);
+    return virPCIDeviceConfigOpenInternal(dev, false, fatal);
 }
 
 static int
 virPCIDeviceConfigOpenWrite(virPCIDevicePtr dev)
 {
-    return virPCIDeviceConfigOpenInternal(dev, true);
+    return virPCIDeviceConfigOpenInternal(dev, false, true);
 }
 
 static void