From: John Ferlan <jferlan@redhat.com>
Date: Tue, 21 Mar 2017 17:33:17 +0000 (-0400)
Subject: network: Remove null newBandwidth check from networkBandwidthUpdate
X-Git-Tag: v3.2.0-rc1~179
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=802579b5d682ccf02928893f0cce6279543f9c4d;p=thirdparty%2Flibvirt.git

network: Remove null newBandwidth check from networkBandwidthUpdate

The prototype requires a NONNULL argument and the only caller passes in
a non-null parameter. Besides the "else if" condition would deref it anyway.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 0336ece35c..875c6f6509 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -5496,7 +5496,7 @@ networkBandwidthUpdate(virDomainNetDefPtr iface,
     /* Okay, there are three possible scenarios: */
 
     if (ifaceBand && ifaceBand->in && ifaceBand->in->floor &&
-        newBandwidth && newBandwidth->in && newBandwidth->in->floor) {
+        newBandwidth->in && newBandwidth->in->floor) {
         /* Either we just need to update @floor .. */
 
         if (virNetDevBandwidthUpdateRate(network->def->bridge,