From: Michael Tremer <michael.tremer@ipfire.org>
Date: Sat, 12 Oct 2024 17:02:30 +0000 (+0000)
Subject: packages: Fail when trying to add invalid dependencies
X-Git-Tag: 0.9.30~1066
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=80276db5b9f9278d20fa486d0d469d7efac0995f;p=pakfire.git

packages: Fail when trying to add invalid dependencies

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/package.c b/src/libpakfire/package.c
index f77cc873b..412186fa8 100644
--- a/src/libpakfire/package.c
+++ b/src/libpakfire/package.c
@@ -1364,10 +1364,8 @@ int pakfire_package_add_dep(struct pakfire_package* pkg,
 		const enum pakfire_package_key key, const char* dep) {
 	// Parse the dependency
 	Id id = pakfire_str2dep(pkg->pakfire, dep);
-
-	// Silently ignore any invalid dependencies
 	if (!id)
-		return 0;
+		return -EINVAL;
 
 	return pakfire_package_add_depid(pkg, key, id);
 }