From: Volker Lendecke <vl@samba.org>
Date: Tue, 20 Jan 2026 11:51:29 +0000 (+0100)
Subject: smbd: Simply return status instead of special-casing errors
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=802e814b8ef1bafa83f11979e761878d98ef0e72;p=thirdparty%2Fsamba.git

smbd: Simply return status instead of special-casing errors

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 1b74e52559d..c5e910204a0 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -5008,11 +5008,7 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbXsrv_connection *xconn)
 	 */
 
 	status = smbd_smb2_request_next_incoming(xconn);
-	if (!NT_STATUS_IS_OK(status)) {
-		return status;
-	}
-
-	return NT_STATUS_OK;
+	return status;
 }
 
 static NTSTATUS smbd_smb2_advance_incoming(struct smbXsrv_connection *xconn, size_t n)
@@ -5208,11 +5204,7 @@ got_full:
 	}
 
 	status = smbd_smb2_request_next_incoming(xconn);
-	if (!NT_STATUS_IS_OK(status)) {
-		return status;
-	}
-
-	return NT_STATUS_OK;
+	return status;
 }
 
 static NTSTATUS smbd_smb2_io_handler(struct smbXsrv_connection *xconn,
@@ -5315,11 +5307,8 @@ again:
 		 */
 		goto again;
 	}
-	if (!NT_STATUS_IS_OK(status)) {
-		return status;
-	}
 
-	return NT_STATUS_OK;
+	return status;
 }
 
 static void smbd_smb2_connection_handler(struct tevent_context *ev,