From: Radostin Stoyanov <rstoyanov1@gmail.com>
Date: Tue, 20 Mar 2018 06:48:44 +0000 (+0000)
Subject: apibuild: Use isinstance for type checking
X-Git-Tag: v4.2.0-rc1~89
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=80559e4879b9c150b2753a44a53cf83b0c4b5355;p=thirdparty%2Flibvirt.git

apibuild: Use isinstance for type checking

The isinstance() function [1] returns true if an object argument is an
instance of a classinfo argument or of a direct, indirect subclass
thereof.

1: https://docs.python.org/3/library/functions.html#isinstance

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
---

diff --git a/docs/apibuild.py b/docs/apibuild.py
index 17d14a0c55..832f04ab15 100755
--- a/docs/apibuild.py
+++ b/docs/apibuild.py
@@ -742,7 +742,7 @@ class CParser:
         return line
 
     def cleanupComment(self):
-        if type(self.comment) != type(""):
+        if not isinstance(self.comment, str):
             return
         # remove the leading * on multi-line comments
         lines = self.comment.splitlines(True)
@@ -2223,9 +2223,8 @@ class docBuilder:
             output.write("    <struct name='%s' file='%s' type='%s'" % (
                      name, self.modulename_file(id.header), id.info))
             name = id.info[7:]
-            if name in self.idx.structs and ( \
-               type(self.idx.structs[name].info) == type(()) or
-                type(self.idx.structs[name].info) == type([])):
+            if (name in self.idx.structs and
+                    isinstance(self.idx.structs[name].info, (list, tuple))):
                 output.write(">\n")
                 try:
                     for field in self.idx.structs[name].info: