From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 22 Nov 2004 20:08:07 +0000 (+0000)
Subject: Absolutely never call close_temp_logs while validating log options.
X-Git-Tag: tor-0.0.9rc1~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=805c9e36736211b8248c6432277dbf65bc92163d;p=thirdparty%2Ftor.git

Absolutely never call close_temp_logs while validating log options.


svn:r2934
---

diff --git a/src/or/config.c b/src/or/config.c
index cc5760f309..5a7d7158ec 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -1785,13 +1785,15 @@ config_init_logs(or_options_t *options, int validate_only)
       ok = 0; goto cleanup;
     }
     if (!strcasecmp(smartlist_get(elts,1), "stdout")) {
-      if (!validate_only)
+      if (!validate_only) {
         add_stream_log(levelMin, levelMax, "<stdout>", stdout);
-      close_temp_logs();
+        close_temp_logs();
+      }
     } else if (!strcasecmp(smartlist_get(elts,1), "stderr")) {
-      if (!validate_only)
+      if (!validate_only) {
         add_stream_log(levelMin, levelMax, "<stderr>", stderr);
-      close_temp_logs();
+        close_temp_logs();
+      }
     } else if (!strcasecmp(smartlist_get(elts,1), "syslog")) {
 #ifdef HAVE_SYSLOG_H
       if (!validate_only)