From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 2 Jan 2017 08:50:24 +0000 (+0100)
Subject: virmacmap: Fix variable handling
X-Git-Tag: v3.0.0-rc1~142
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=806582a5d1b9fa915810cf4d9df87f13e5ee92e4;p=thirdparty%2Flibvirt.git

virmacmap: Fix variable handling

In virMacMapRemoveLocked() we have two variables: @macsList and
@newMacsList. Obviously, @newMacsList is supposed to hold pointer
to modified list but in fact it holds pointer to the old list.
It's confusing.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/util/virmacmap.c b/src/util/virmacmap.c
index 36c364e100..11b3e03346 100644
--- a/src/util/virmacmap.c
+++ b/src/util/virmacmap.c
@@ -121,8 +121,8 @@ virMacMapRemoveLocked(virMacMapPtr mgr,
         return 0;
 
     newMacsList = macsList;
-    virStringListRemove(&macsList, mac);
-    if (!macsList) {
+    virStringListRemove(&newMacsList, mac);
+    if (!newMacsList) {
         virHashSteal(mgr->macs, domain);
     } else {
         if (macsList != newMacsList &&