From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 30 Sep 2019 14:37:48 +0000 (+0200)
Subject: qemu: checkpoint: Don't update current checkpoint until we are done
X-Git-Tag: v5.8.0-rc1~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=808fa349f3e9c89702c84a307ab867ef2b4799c1;p=thirdparty%2Flibvirt.git

qemu: checkpoint: Don't update current checkpoint until we are done

Similarly to the snapshot code there's no reason to modify current
checkpoint until we are done creating the new one.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
index 0d90bbec14..8856a90ce8 100644
--- a/src/qemu/qemu_checkpoint.c
+++ b/src/qemu/qemu_checkpoint.c
@@ -412,13 +412,6 @@ qemuCheckpointCreateXML(virDomainPtr domain,
         if (!redefine &&
             VIR_STRDUP(chk->def->parent_name, other->def->name) < 0)
             goto endjob;
-        if (update_current) {
-            virDomainCheckpointSetCurrent(vm->checkpoints, NULL);
-            if (qemuCheckpointWriteMetadata(vm, other,
-                                            driver->caps, driver->xmlopt,
-                                            cfg->checkpointDir) < 0)
-                goto endjob;
-        }
     }
 
     /* actually do the checkpoint */