From: Rico Tzschichholz Date: Tue, 11 Apr 2023 10:21:14 +0000 (+0200) Subject: vala: Don't report consequential error when base_method is incompatible already X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=80c8249a8156412f5c07b33d63b8c73bd597be84;p=thirdparty%2Fvala.git vala: Don't report consequential error when base_method is incompatible already --- diff --git a/vala/valamethod.vala b/vala/valamethod.vala index c95d3ae43..76dcbb5d3 100644 --- a/vala/valamethod.vala +++ b/vala/valamethod.vala @@ -1046,7 +1046,8 @@ public class Vala.Method : Subroutine, Callable, GenericSymbol { if (overrides && base_method == null && base_interface_method != null && base_interface_method.is_abstract) { Report.warning (source_reference, "`override' not required to implement `abstract' interface method `%s'", base_interface_method.get_full_name ()); overrides = false; - } else if (overrides && base_method == null && base_interface_method == null) { + } else if (!error && overrides && base_method == null && base_interface_method == null) { + error = true; Report.error (source_reference, "`%s': no suitable method found to override", get_full_name ()); } else if ((is_abstract || is_virtual || overrides) && access == SymbolAccessibility.PRIVATE) { error = true;