From: Nick Zitzmann <nickzman@gmail.com>
Date: Wed, 20 Feb 2013 02:03:39 +0000 (-0700)
Subject: metalink: fix improbable crash parsing metalink filename
X-Git-Tag: curl-7_30_0~318
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=80e2b3edb9755ff915185b4fbfa285d482c6bfc6;p=thirdparty%2Fcurl.git

metalink: fix improbable crash parsing metalink filename

The this_url pointer wasn't being initialized, so if strdup() would return
null when copying the filename in a metalink file, then hilarity would
ensue during the cleanup phase. This change was brought to you by clang,
which noticed this and raised a warning.
---

diff --git a/src/tool_operate.c b/src/tool_operate.c
index 4166fc2ef9..5e73d86d4e 100644
--- a/src/tool_operate.c
+++ b/src/tool_operate.c
@@ -535,7 +535,7 @@ int operate(struct Configurable *config, int argc, argv_item_t argv[])
         long retry_numretries;
         long retry_sleep_default;
         long retry_sleep;
-        char *this_url;
+        char *this_url = NULL;
         int metalink_next_res = 0;
 
         outfile = NULL;