From: terry%mozilla.org <>
Date: Fri, 24 Sep 1999 02:19:01 +0000 (+0000)
Subject: Patch by holger@holger.om.org (Holger Schurig) -- several cleanups.
X-Git-Tag: bugzilla-2.8~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=80e66f4380525ec512995544fc13e01e88b55344;p=thirdparty%2Fbugzilla.git

Patch by holger@holger.om.org (Holger Schurig) -- several cleanups.
---

diff --git a/CGI.pl b/CGI.pl
index c12ce8e5e7..0d9762b222 100644
--- a/CGI.pl
+++ b/CGI.pl
@@ -29,11 +29,9 @@ require 'globals.pl';
 
 sub GeneratePersonInput {
     my ($field, $required, $def_value, $extraJavaScript) = (@_);
-    if (!defined $extraJavaScript) {
-        $extraJavaScript = "";
-    }
+    $extraJavaScript ||= "";
     if ($extraJavaScript ne "") {
-        $extraJavaScript = "onChange=\" $extraJavaScript \"";
+        $extraJavaScript = "onChange=\"$extraJavaScript\"";
     }
     return "<INPUT NAME=\"$field\" SIZE=32 $extraJavaScript VALUE=\"$def_value\">";
 }
diff --git a/buglist.cgi b/buglist.cgi
index ee4aa39fd3..8d3182200d 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -546,14 +546,13 @@ while (@row = FetchSQLData()) {
                 next;
             }
             my $value = shift @row;
-            my $nowrap = "";
 
             if ($::needquote{$c}) {
                 $value = html_quote($value);
             } else {
                 $value = "<nobr>$value</nobr>";
             }
-            pnl "<td $nowrap>$value";
+            pnl "<td>$value";
         }
         if ($dotweak) {
             my $value = shift @row;
diff --git a/query.cgi b/query.cgi
index bee45e9f41..5f8d362149 100755
--- a/query.cgi
+++ b/query.cgi
@@ -57,7 +57,7 @@ if (!defined $::buffer || $::buffer eq "") {
     $::buffer = $::COOKIE{"DEFAULTQUERY"};
 }
 
-my %default;
+use vars qw(%default);
 my %type;
 
 foreach my $name ("bug_status", "resolution", "assigned_to", "rep_platform",
diff --git a/reports.cgi b/reports.cgi
index c7a22fcd32..21cfd780e3 100755
--- a/reports.cgi
+++ b/reports.cgi
@@ -261,6 +261,9 @@ FIN
 	# start painting report #
 	#########################
 
+        $bugs_status{'NEW'}      ||= '0';
+        $bugs_status{'ASSIGNED'} ||= '0';
+        $bugs_status{'REOPENED'} ||= '0';
 	print <<FIN;
 <h1>$quip</h1>
 <table border=1 cellpadding=5>