From: Marco Bettini <marco.bettini@open-xchange.com>
Date: Wed, 27 Apr 2022 09:12:31 +0000 (+0000)
Subject: fts-flatcurve: cmd_fts_flatcurve_mailbox_run() - Fix NULL check on fuser after pointe... 
X-Git-Tag: 2.4.0~4098
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=80ec204d67bb407c1c8fee092dc00d6f4e1be0d1;p=thirdparty%2Fdovecot%2Fcore.git

fts-flatcurve: cmd_fts_flatcurve_mailbox_run() - Fix NULL check on fuser after pointer has been already dereferenced

Found by Coverity
---

diff --git a/src/plugins/fts-flatcurve/doveadm-fts-flatcurve.c b/src/plugins/fts-flatcurve/doveadm-fts-flatcurve.c
index 3a075e4269..bfec839dfb 100644
--- a/src/plugins/fts-flatcurve/doveadm-fts-flatcurve.c
+++ b/src/plugins/fts-flatcurve/doveadm-fts-flatcurve.c
@@ -149,10 +149,9 @@ cmd_fts_flatcurve_mailbox_run(struct doveadm_mail_cmd_context *_ctx,
 		(struct fts_flatcurve_mailbox_cmd_context *)_ctx;
 	struct fts_flatcurve_user *fuser =
 		FTS_FLATCURVE_USER_CONTEXT(user);
-	struct flatcurve_fts_backend *backend = fuser->backend;
 
 	if (fuser == NULL) {
-		e_error(backend->event, FTS_FLATCURVE_LABEL " not enabled");
+		e_error(user->event, FTS_FLATCURVE_LABEL " not enabled");
 		doveadm_mail_failed_error(_ctx, MAIL_ERROR_NOTFOUND);
 		_ctx->exit_code = EX_UNAVAILABLE;
 		return -1;
@@ -177,6 +176,7 @@ cmd_fts_flatcurve_mailbox_run(struct doveadm_mail_cmd_context *_ctx,
 		break;
 	}
 
+	struct flatcurve_fts_backend *backend = fuser->backend;
 	int ret = cmd_fts_flatcurve_mailbox_run_do(backend, user, ctx);
 	if (ret < 0)
 		_ctx->exit_code = EX_TEMPFAIL;