From: Amos Jeffries <squid3@treenet.co.nz>
Date: Fri, 17 Jun 2011 13:06:12 +0000 (-0600)
Subject: Fix RADIUS helper resource leak
X-Git-Tag: SQUID_3_1_12_3~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=80f28c5bf86395edc408f7ad23fbd0d43e587928;p=thirdparty%2Fsquid.git

Fix RADIUS helper resource leak

cppcheck detected the config file was never closed/released. This could
prevent the helper shutting down cleanly.
---

diff --git a/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c b/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
index 20ab75c8e0..ea4c0686f7 100644
--- a/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
+++ b/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
@@ -263,6 +263,7 @@ rad_auth_config(const char *cfname)
         if (!memcmp(line, "port", 4))
             sscanf(line, "port %s", svc_name);
     }
+    fclose(cf);
     if (srv && crt)
         return 0;
     return -1;