From: Nick Porter <nick@portercomputing.co.uk>
Date: Mon, 28 Apr 2025 11:10:17 +0000 (+0100)
Subject: Better assert for boxes which can be truthy
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8121eda170ece13b337b2ad3f9d4cf51e3d39b81;p=thirdparty%2Ffreeradius-server.git

Better assert for boxes which can be truthy

Testing fr_type_is_leaf excludes FR_TYPE_NULL, which is a valid "false"
box.
---

diff --git a/src/lib/unlang/xlat_expr.c b/src/lib/unlang/xlat_expr.c
index d40d2b5b49..2910adf473 100644
--- a/src/lib/unlang/xlat_expr.c
+++ b/src/lib/unlang/xlat_expr.c
@@ -1081,7 +1081,7 @@ static bool xlat_logical_or(xlat_logical_rctx_t *rctx, fr_value_box_list_t const
 	 *	Loop over the input list.  We CANNOT do groups.
 	 */
 	fr_value_box_list_foreach(in, box) {
-		fr_assert(fr_type_is_leaf(box->type));
+		fr_assert(fr_type_is_leaf(box->type) || fr_type_is_null(box->type));
 
 		last = box;