From: Stephen Finucane <stephen.finucane@intel.com>
Date: Mon, 21 Mar 2016 17:37:42 +0000 (+0000)
Subject: views: Use context dictionaries in '__init__'
X-Git-Tag: v2.0.0-rc1~398
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=814306b78347d7b1f821542732e523530701f0f9;p=thirdparty%2Fpatchwork.git

views: Use context dictionaries in '__init__'

Remove the use of PatchworkRequestContext in one function of this view
as it is not required and causes a 'RemovedInDjango110Warning' warning.
This requires the use of 'render', rather than 'render_to_response'.

The remaining use of this context option will be addressed in a
follow-up patch.

Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Tested-by: Andy Doan <andy.doan@linaro.org>
---

diff --git a/patchwork/views/__init__.py b/patchwork/views/__init__.py
index 46ff7d61..5a5c3708 100644
--- a/patchwork/views/__init__.py
+++ b/patchwork/views/__init__.py
@@ -28,7 +28,7 @@ import email.utils
 import re
 
 from django.http import Http404
-from django.shortcuts import render_to_response, get_object_or_404
+from django.shortcuts import render, get_object_or_404
 
 from patchwork.forms import MultiplePatchForm
 from patchwork.models import (Bundle, BundlePatch, Comment, Patch,
@@ -388,11 +388,11 @@ def confirm(request, key):
     if conf.active and conf.is_valid():
         return views[conf.type](request, conf)
 
-    context = PatchworkRequestContext(request)
+    context = {}
     context['conf'] = conf
     if not conf.active:
         context['error'] = 'inactive'
     elif not conf.is_valid():
         context['error'] = 'expired'
 
-    return render_to_response('patchwork/confirm-error.html', context)
+    return render(request, 'patchwork/confirm-error.html', context)