From: Willy Tarreau <w@1wt.eu>
Date: Mon, 5 Nov 2012 23:14:25 +0000 (+0100)
Subject: BUG/MINOR: session: mark the handshake as complete earlier
X-Git-Tag: v1.5-dev13~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=815f5ecffa3acfe87eb4e62c085ca49b4057fe5b;p=thirdparty%2Fhaproxy.git

BUG/MINOR: session: mark the handshake as complete earlier

There is a small waste of CPU cycles when no handshake is required on an
accepted connection, because we had to perform one call to conn_fd_handler()
to mark the connection CONNECTED and to call process_session() again to say
that nothing happened.

By marking the connection CONNECTED when there is no pending handshake, we
avoid this extra call to process_session().
---

diff --git a/src/session.c b/src/session.c
index 04eee61722..6bb44f021a 100644
--- a/src/session.c
+++ b/src/session.c
@@ -210,7 +210,8 @@ int session_accept(struct listener *l, int cfd, struct sockaddr_storage *addr)
 		return 1;
 	}
 
-	/* OK let's complete session initialization */
+	/* OK let's complete session initialization since there is no handshake */
+	s->si[0].conn->flags |= CO_FL_CONNECTED;
 	ret = session_complete(s);
 	if (ret > 0)
 		return ret;