From: Volker Lendecke <vl@samba.org>
Date: Thu, 19 Apr 2012 08:20:27 +0000 (+0200)
Subject: s3: Fix Coverity ID 2747: FORWARD_NULL
X-Git-Tag: samba-4.0.0alpha20~184
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8173331150482b78e85c005fcea2c7d80f430f65;p=thirdparty%2Fsamba.git

s3: Fix Coverity ID 2747: FORWARD_NULL

For the notify cleanup process we have a notify context without a
messaging entry. We will never call notify_add/remove for this, but
the code should protect against this.
---

diff --git a/source3/smbd/notify_internal.c b/source3/smbd/notify_internal.c
index 27fe21214b3..aa02e32a2f1 100644
--- a/source3/smbd/notify_internal.c
+++ b/source3/smbd/notify_internal.c
@@ -393,7 +393,7 @@ NTSTATUS notify_remove(struct notify_context *notify, void *private_data)
 	struct db_record *notify_rec;
 	NTSTATUS status;
 
-	if (notify == NULL) {
+	if ((notify == NULL) || (notify->msg == NULL)) {
 		return NT_STATUS_NOT_IMPLEMENTED;
 	}