From: Timo Sirainen <tss@iki.fi>
Date: Thu, 23 Oct 2003 08:30:04 +0000 (+0300)
Subject: p_strndup() read str[max_chars] byte - could have possibly crashed in some
X-Git-Tag: 1.1.alpha1~4268
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=81814e65211703cd2b701dc65c197dbee9c17072;p=thirdparty%2Fdovecot%2Fcore.git

p_strndup() read str[max_chars] byte - could have possibly crashed in some
rare conditions

--HG--
branch : HEAD
---

diff --git a/src/lib/strfuncs.c b/src/lib/strfuncs.c
index 0543874d69..f95c5732d1 100644
--- a/src/lib/strfuncs.c
+++ b/src/lib/strfuncs.c
@@ -168,7 +168,7 @@ char *p_strndup(pool_t pool, const void *str, size_t max_chars)
 		return NULL;
 
 	len = 0;
-	while (((const char *) str)[len] != '\0' && len < max_chars)
+	while (len < max_chars && ((const char *) str)[len] != '\0')
 		len++;
 
 	mem = p_malloc(pool, len+1);