From: Jason Ish <jason.ish@oisf.net>
Date: Sun, 6 Jul 2025 17:31:52 +0000 (-0600)
Subject: runner: raise UnsatisfiedRequirementError for windows shell checks
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8187ba8fb55b6de18ec2d9ea6f3f81a53834357c;p=thirdparty%2Fsuricata-verify.git

runner: raise UnsatisfiedRequirementError for windows shell checks

Instead of just printing that shell checks are not supported on
Windows, properly skip the test so it is counted as skipped.
---

diff --git a/run.py b/run.py
index 1b3ade35e..f9967eaa3 100755
--- a/run.py
+++ b/run.py
@@ -469,8 +469,7 @@ class FileCompareCheck:
 
     def run(self):
         if WIN32:
-            print("skipping shell check on windows")
-            return True;
+            raise UnsatisfiedRequirementError("shell check not supported on Windows")
         expected = os.path.join(self.directory, self.config["expected"])
         filename = self.config["filename"]
         try:
@@ -505,8 +504,7 @@ class ShellCheck:
 
         try:
             if WIN32:
-                print("skipping shell check on windows")
-                return True;
+                raise UnsatisfiedRequirementError("shell check not supported on Windows")
             output = subprocess.check_output(self.config["args"], shell=True, env=self.env)
             if "expect" in self.config:
                 return str(self.config["expect"]) == output.decode().strip()