From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Wed, 28 Jul 2021 05:00:09 +0000 (+1200)
Subject: tests/krb5: Expect e-data except when the error code is KDC_ERR_GENERIC
X-Git-Tag: ldb-2.5.0~953
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8194b2a2611c6b1db2d29ec22c70e14decd1784b;p=thirdparty%2Fsamba.git

tests/krb5: Expect e-data except when the error code is KDC_ERR_GENERIC

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/python/samba/tests/krb5/raw_testcase.py b/python/samba/tests/krb5/raw_testcase.py
index 1c08b76061f..c0e997a86a1 100644
--- a/python/samba/tests/krb5/raw_testcase.py
+++ b/python/samba/tests/krb5/raw_testcase.py
@@ -40,6 +40,7 @@ from samba.tests import TestCaseInTempDir
 import samba.tests.krb5.rfc4120_pyasn1 as krb5_asn1
 from samba.tests.krb5.rfc4120_constants import (
     KDC_ERR_ETYPE_NOSUPP,
+    KDC_ERR_GENERIC,
     KDC_ERR_PREAUTH_REQUIRED,
     KRB_AP_REQ,
     KRB_AS_REP,
@@ -1799,7 +1800,7 @@ class RawKerberosTest(TestCaseInTempDir):
         self.assertElementEqualPrincipal(rep, 'sname', expected_sname)
         if self.strict_checking:
             self.assertElementMissing(rep, 'e-text')
-        if expected_error_mode != KDC_ERR_PREAUTH_REQUIRED:
+        if expected_error_mode == KDC_ERR_GENERIC:
             self.assertElementMissing(rep, 'e-data')
             return
         edata = self.getElementValue(rep, 'e-data')
diff --git a/python/samba/tests/krb5/rfc4120_constants.py b/python/samba/tests/krb5/rfc4120_constants.py
index adcc93e1d6b..b00b8b48ae5 100644
--- a/python/samba/tests/krb5/rfc4120_constants.py
+++ b/python/samba/tests/krb5/rfc4120_constants.py
@@ -58,6 +58,7 @@ KDC_ERR_PREAUTH_FAILED = 24
 KDC_ERR_PREAUTH_REQUIRED = 25
 KDC_ERR_BADMATCH = 36
 KDC_ERR_SKEW = 37
+KDC_ERR_GENERIC = 60
 
 # Name types
 NT_UNKNOWN = int(krb5_asn1.NameTypeValues('kRB5-NT-UNKNOWN'))