From: Alexei Gradinari <alex2grad@gmail.com>
Date: Thu, 21 Jul 2016 15:28:36 +0000 (-0400)
Subject: res_pjsip_pubsub: fixed a bug when pjsip_tx_data_dec_ref is called twice.
X-Git-Tag: 15.0.0-beta1~801^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=81ea024d939530b76abca07b37fda0b502d0786a;p=thirdparty%2Fasterisk.git

res_pjsip_pubsub: fixed a bug when pjsip_tx_data_dec_ref is called twice.

This patch removed call of pjsip_tx_data_dec_ref in send_notify
if send_request failed.
The pjsip_dlg_send_request deletes the message on error by itself.

It seems this patch fixes next issues:
ASTERISK-26199
ASTERISK-26166
ASTERISK-26174

Change-Id: I8b05917c93d993f95d604c042ace5f1a5500f59a
---

diff --git a/res/res_pjsip_pubsub.c b/res/res_pjsip_pubsub.c
index 207fae04c1..fe16c613ab 100644
--- a/res/res_pjsip_pubsub.c
+++ b/res/res_pjsip_pubsub.c
@@ -2249,7 +2249,7 @@ static int send_notify(struct sip_subscription_tree *sub_tree, unsigned int forc
 	}
 
 	if (sip_subscription_send_request(sub_tree, tdata)) {
-		pjsip_tx_data_dec_ref(tdata);
+		/* do not call pjsip_tx_data_dec_ref(tdata). The pjsip_dlg_send_request deletes the message on error */
 		return -1;
 	}