From: Oliver Kurth <okurth@vmware.com>
Date: Mon, 15 Apr 2019 18:33:00 +0000 (-0700)
Subject: Fix a leak if VGAuth setup fails.  Coverity issue
X-Git-Tag: stable-11.0.0~115
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=82169f198925c9aa27bd04fd665eac67396adbe7;p=thirdparty%2Fopen-vm-tools.git

Fix a leak if VGAuth setup fails.  Coverity issue
---

diff --git a/open-vm-tools/vgauth/serviceImpl/service.c b/open-vm-tools/vgauth/serviceImpl/service.c
index 677953081..d4716526c 100644
--- a/open-vm-tools/vgauth/serviceImpl/service.c
+++ b/open-vm-tools/vgauth/serviceImpl/service.c
@@ -1,5 +1,5 @@
 /*********************************************************
- * Copyright (C) 2011-2016 VMware, Inc. All rights reserved.
+ * Copyright (C) 2011-2016,2019 VMware, Inc. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU Lesser General Public License as published
@@ -173,6 +173,7 @@ ServiceCreatePublicConnection(ServiceConnection **returnConn) // OUT
 
    if (VGAUTH_E_OK != err) {
       Warning("%s: failed to setup public listen channel\n", __FUNCTION__);
+      ServiceConnectionShutdown(newConn);
       return err;
    }